-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Torch implementation (all classes excluding SL3) #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in SE3). untested
… (N, P, 1) structure where N is the batch dim. and P is the parameterization dim.
…after batch and parameter dimensions)
…t_vector testing fx
…ation for angles near pi, and batchify pi mask
… and added rand fx. in SE_2(3)
… name overlap with 'MatrixLieGroup' needs to be addressed
…rch to avoid naming conflict with np implementation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just need to add torch to this list i think:
Also, for the dimensionality thing, if its just something thats not supported right now you can throw a value error
and write a comment that its a TODO or something |
CharlesCossette
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
first pass at full torch implementation. making this now so you guys can start looking at it while I finish it up.
checklist of things left to add (that I know of):
np
cross-validation. maybe a quick addition to brute force alogm
test in batchdocumentation. base class is definitely lacking relative to thenp
base.py
and the dimensionality rules need to be explained so it doesn't get confusingeditnp
test_so3.py
because I added ordering to theto_euler
functionSO2
)