Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DOCSUM_ATTRIBS with unused property 0x19 #154

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

adepasquale
Copy link

DOCSUM_ATTRIBS needs to have an additional unused slot between digi_sig (0x18) and content_type (0x1A). I have modified the code to use None as a placeholder for ununsed properties, since there are now two of them (0x12 and 0x19). Also updated links to Microsoft documentation.

References:
https://learn.microsoft.com/en-us/openspecs/office_file_formats/ms-oshared/3ef02e83-afef-4b6c-9585-c109edd24e07 https://www.virustotal.com/gui/file/3918ac1e64bb10f1ab2f8651f0165fb4f9c151c38dc9395540f53ef5e22aeb0c

DOCSUM_ATTRIBS needs to have an additional unused slot between digi_sig
(0x18) and content_type (0x1A). I have modified the code to use `None`
as a placeholder for ununsed properties, since there are now two of them
(0x12 and 0x19). Also updated links to Microsoft documentation.

References:
https://learn.microsoft.com/en-us/openspecs/office_file_formats/ms-oshared/3ef02e83-afef-4b6c-9585-c109edd24e07
https://www.virustotal.com/gui/file/3918ac1e64bb10f1ab2f8651f0165fb4f9c151c38dc9395540f53ef5e22aeb0c
@decalage2 decalage2 self-requested a review November 2, 2023 21:51
@decalage2 decalage2 self-assigned this Nov 2, 2023
@decalage2 decalage2 added this to the olefile 0.50 milestone Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants