Merge pull request #438 from debtcollective/od/fix

Run subscription charge job once a day, and fix phone number issue on Mailchimp

app/jobs/subscribe_user_to_newsletter_job.rb

@@ -82,7 +82,7 @@ def merge_fields(user)
     # TODO: validation until we implement a better one on the union widget/membership controller
     # Mailchimp fails if the phone number is not valid
     phone_number = user.phone_number
-    if phone_number.length >= 8
+    if phone_number&.length.to_i >= 7 && phone_number&.length.to_i <= 15
       merge_fields_hash[:PHONE] = phone_number
     end
 

config/sidekiq.yml

@@ -5,7 +5,7 @@
   - mailers
 :schedule:
   find_overdue_subscriptions:
-    every: '12h'
+    every: "24h"
     queue: default
     class: FindOverdueSubscriptionsJob
-    description: 'This job finds all active overdue subscriptions and creates a sidekiq job to charge the subscriber'
+    description: "This job finds all active overdue subscriptions and creates a sidekiq job to charge the subscriber"

cypress/integration/membership.spec.js

@@ -44,7 +44,6 @@ describe('Membership Spec', () => {
       cy.get("input[name='last-name']").type(faker.name.lastName())
       cy.get("input[name='email']").type(faker.internet.email())
       cy.get("input[name='phone-number']").type(faker.phone.phoneNumber())
-      cy.get("select[name='chapter']").select('none')
 
       cy.getWithinIframe('[name="cardnumber"]').type('4242424242424242')
       cy.getWithinIframe('[name="exp-date"]').type('1232')