Refactored FindAllBox #150
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deathmarine
force-pushed
the
master
branch
2 times, most recently
from
43b5f44 to
26fe3a2
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FindAllBoxhandles a "FindAll" widget, among its responsibilities, it maintains a progress bar.I have refactored out the progress bar logic to a helper object, as it simplified the logic in
FindAllBoxand left it to manage the UI components in a higher level.For more information about "Extract Class" refactoring. see https://refactoring.guru/extract-class
We created this refactoring using automatic tools. See our website
www.refactormachine.com
Performed extract class operation for
FindAllBox.Extracted fields:
progressBar,statusLabel.Extracted Methods:
setStatus(),initProgressBar().