Skip to content

Commit

Permalink
build: drop usage of .postN
Browse files Browse the repository at this point in the history
  • Loading branch information
kiyoon committed Oct 17, 2024
1 parent 7dca366 commit c67fd99
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 5 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/build_and_release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ on:
required: true
default: 3.4.1
version-tag:
description: Python package version to release to PyPI (without 'v')
description: Python package version to release to PyPI (without 'v', last digit is the build number)
required: true
default: 3.4.1.post1
default: 3.4.1.1
dry-run:
description: Dry run
type: boolean
Expand Down
7 changes: 5 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,10 @@ Go to Github Actions and run the `Build and Release` workflow.

Version rule:

3.4.1.post2: 3.4.1 is the APBS version, postN can increase with the changes of the package and the builds.
3.4.1.2:

- 3.4.1 is the APBS version
- the last digit (.2) is the patch/build number. It increases as we rebuild the wheels with different configurations or update the python API.


### Running locally
Expand Down Expand Up @@ -73,7 +76,7 @@ Build four wheels on all platforms. Basically it will put the binaries in the `s
```bash
# first arg: APBS version to find in `data/` (i.e. data/apbs-3.4.1/APBS-3.4.1.Linux)
# second arg: wheel version
bash build_python.sh 3.4.1 3.4.1.post2
bash build_python.sh 3.4.1 3.4.1.2
```

Test the wheel
Expand Down
3 changes: 2 additions & 1 deletion build_python.sh
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
if [ "$#" -ne 2 ]; then
echo "Build python wheels in a temp directory."
echo "Usage: $0 <apbs_version> <py_package_version>"
echo "Example: $0 3.4.1 3.4.1.post4"
echo "Example: $0 3.4.1 3.4.1.4"
echo "The python package version should be the same as the APBS version plus a patch (build) version."
exit 1
fi

Expand Down

0 comments on commit c67fd99

Please sign in to comment.