Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix annotated type variables with distinct types #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix annotated type variables with distinct types #30

wants to merge 1 commit into from

Conversation

kikofernandez
Copy link

as per OTP pull request #7717, duplicate annotation variables that have different types will not be allowed in OTP-27.

this PR simply re-writes the type specification so that it is compliant with the OTP change.

@kikofernandez
fix annotated type variables with distinct types
a430ce5 
as per OTP pull request
[#7717](erlang/otp#7717), duplicate annotation
types will not be allowed in OTP-27.

this PR simply re-writes the type specification so that it is compliant
with the OTP change.
@kikofernandez
Copy link
Author

kikofernandez commented Oct 9, 2023 •
edited
Loading

never mind. As long as the annotated variables have the same type, there is no issue.
closing.

@kikofernandez kikofernandez reopened this Oct 13, 2023
@kikofernandez
Copy link
Author

Re-opening the PR, I realised that the UserState annotation is sometimes written with type term() and sometimes with type user_state(). This will not be valid code in OTP-27, thus the PR.

@kikofernandez kikofernandez mentioned this pull request Nov 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kikofernandez