Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement running and total mnesia node count metrics #115

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

luos
Copy link

@luos luos commented Jan 8, 2021

Hi,

It would be useful for us to expose running and total mnesia node counts.
Let me know what you think.

Thanks

@luos luos force-pushed the add_mnesia_running_node_metric2 branch from 2314751 to 925b7d1 Compare January 8, 2021 16:16
@luos luos changed the title implement running and total mnesia node metrics implement running and total mnesia node count metrics Jan 8, 2021
@deadtrickster
Copy link
Owner

Hi, I'm somewhat concerned with arity here. can peer label explode?

@luos
Copy link
Author

luos commented Jan 11, 2021

Hi,

I guess, that is a a good question. In our typical installation it's about a maximum of 7 nodes connected in an mnesia cluster. It should be same or less than the node_state metric coming from the dist collector (if all nodes online).

I am not sure if others use many more mnesia nodes?

If you have many nodes, let's say the mentioned 7, that would create 7*6 metrics in total, so I guess you can get somewhat flooded by these. Though if you already have 7 nodes added, an additional 6 metrics for each should not be a problem.

Another case I thought of can be if people have dynamic nodes in a cluster and do not clean up the removed/shutdown nodes properly, but I guess then that is more of a bug than intended.

@luos
Copy link
Author

luos commented Jan 19, 2021

Hi,

Do you think this can be merged, should I change something? Do you still have concerns?

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants