correct merging of [ atomtypes ] when bondtypes are used within. #21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging [ atomtypes ] with _merge_FF_files() in alchemy.py was retaining only the first 6 columns.
However when [ atomtypes ] also had a bond type or an atom number column, the final epsilon column would get cut off.
Eg.
c3 c3 0.00000 0.00000 A 3.39967e-01 4.57730e-01
would become
c3 c3 0.00000 0.00000 A 3.39967e-01
when we want
c3 0.00000 0.00000 A 3.39967e-01 4.57730e-01
This change parses the input [ atomtypes ], recognizes whether these optional columns are present, and outputs only the required columns (ie no bond type and no atom number) into the merged file.
There is also a new unit test to verify functionality on both GAFF and OPLS atomtypes formats.
CGENFF ligands tend to directly include the charmm ff and have empty [ atomtypes ] sections, so testing on them is pointless.