Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md to include an example for Laravel #23

Closed
wants to merge 2 commits into from
Closed

Update README.md to include an example for Laravel #23

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a82252b
Update README.md
rozenlicht Apr 14, 2023
765223d
Update README.md
rozenlicht Apr 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ SHELL=/bin/bash
**Laravel scheduler**: A cron to run the Laravel scheduler every minute would be:

```yaml
- exec: printf "SHELL=/bin/bash\n* * * * * cd /var/www/html && php artisan schedule:run >> /dev/null 2>&1\n" | crontab
- exec: printf "SHELL=/bin/bash\n* * * * * cd /var/www/html && IS_DDEV_PROJECT=true php artisan schedule:run >> /dev/null 2>&1\n" | crontab
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is apparently a hook to create a cron. I think it would be better to just show how to create the cron? Or if you like doing this in a (post-start hook?) then explain that. But I think this will then create it every time you ddev start. It might be more fun to add it to a .ddev/web-build/Dockerfile where it only gets created once.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rfay
This is consistent with the other framework examples though, isn't it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably all of them need some work; they need to show the whole hooks stanza, and they should probably check to see if the cron is already there. Because you can do a ddev start when it's already running and enter the cron multiple times.

I think it would be far better for all the examples to add the cron in Dockerfile if possible, post-start hook is really, really messy.


```

Expand Down