Skip to content

Commit

Permalink
going to CRAN
Browse files Browse the repository at this point in the history
  • Loading branch information
SymbolixAU committed May 13, 2020
1 parent a66076a commit 824e0fb
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 26 deletions.
4 changes: 2 additions & 2 deletions DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
Package: sfheaders
Type: Package
Title: Converts Between R Objects and Simple Feature Objects
Date: 2020-03-19
Version: 0.2.1006
Date: 2020-05-15
Version: 0.2.2
Authors@R: c(
person("David", "Cooley", ,"[email protected]", role = c("aut", "cre")),
person(given = "Michael", family = "Sumner", role = "ctb")
Expand Down
1 change: 0 additions & 1 deletion NEWS.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@

# v0.2.2

*
* crs structure matches new `sf` definition [issue49](https://github.com/dcooley/sfheaders/issues/49)
* `sf_to_df()` adds `sfc_columns` attributes to identify which of the columns form the coordinates [issue50](https://github.com/dcooley/sfheaders/issues/50)
* `XYM` dimensions correctly handled
Expand Down
25 changes: 2 additions & 23 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,27 +1,6 @@

* updates v0.1.0 to v0.2.2
* skipping over v0.2.1

## clang and gcc UBSAN errors

The previous version found

> clang-UBSAN
> <https://www.stats.ox.ac.uk/pub/bdr/memtests/clang-UBSAN/sfheaders>
> gcc-UBSAN
> <https://www.stats.ox.ac.uk/pub/bdr/memtests/gcc-UBSAN/sfheaders>
> sfheaders.Rcheck/tests/testthat.Rout:/usr/include/c++/9/bits/stl_vector.h:1043:34:
runtime error: reference binding to null pointer of type 'value_type'
> sfheaders.Rcheck/tests/testthat.Rout:/usr/local/bin/../include/c++/v1/vector:1549:12:
runtime error: reference binding to null pointer of type 'long'


These were due to me incorrectly using a 'long' to index a vector, where I should have used 'int'. This has been fixed in [this commit](https://github.com/dcooley/sfheaders/commit/4b0514bfe3df45a0de9b4c6f71804d638d95c7f2#diff-7a5d477089d3ceb79e115d2dde0cfef0)

Checked with `rhub::check_with_sanitizers()` and `rhub::check_for_cran()`


* updates v0.2.1 to v0.2.2
* Checked with `rhub::check_with_sanitizers()` and `rhub::check_for_cran()`

## Test environments

Expand Down

0 comments on commit 824e0fb

Please sign in to comment.