Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dynamic schema names rather than hardcoded ones #224

Merged
merged 7 commits into from
Nov 22, 2024

Conversation

dbeatty10
Copy link
Contributor

@dbeatty10 dbeatty10 commented Nov 22, 2024

resolves #223

Problem

There can be permissions errors if different database users are trying to modify the same hardcoded schema.

This can be the case if there are two different CI systems running at the same time (as is the case currently with CircleCI (legacy) and GitHub Actions (new)).

Solution

Remove schemas that are completely hardcoded and use a schema name based on target.schema instead.

Changing the upstream table changed the expected output slightly, and I updated the expectation to match. I think this is okay, especially since I didn't change the logic of any macros -- I only changed the upstream model definitions and the downstream expected output.

Checklist

  • This code is associated with an issue which has been triaged and [accepted for development]

@dbeatty10 dbeatty10 marked this pull request as ready for review November 22, 2024 21:18
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Nov 22, 2024
@dbeatty10 dbeatty10 merged commit b28ab7d into main Nov 22, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use dynamic schema names rather than hardcoded ones
1 participant