Use dynamic schema names rather than hardcoded ones #224
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #223
Problem
There can be permissions errors if different database users are trying to modify the same hardcoded schema.
This can be the case if there are two different CI systems running at the same time (as is the case currently with CircleCI (legacy) and GitHub Actions (new)).
Solution
Remove schemas that are completely hardcoded and use a schema name based on
target.schema
instead.Changing the upstream table changed the expected output slightly, and I updated the expectation to match. I think this is okay, especially since I didn't change the logic of any macros -- I only changed the upstream model definitions and the downstream expected output.
Checklist