Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore CI test for case-sensitive identifiers when generating sources #192

Merged
merged 6 commits into from
Nov 19, 2024

Conversation

dbeatty10
Copy link
Contributor

@dbeatty10 dbeatty10 commented Nov 19, 2024

resolves #184

Problem

The integration test for the #168 feature was removed in https://github.com/dbt-labs/dbt-codegen/pull/174/files.

Solution

Restore the test that was removed and make updates as-needed so that it works across databases.

This was possible for dbt-redshift because in the interim, we had already updated the enable_case_sensitive_identifier setting to true in the cluster’s parameter group via the Amazon Redshift console. Backstory accessible via dbt-labs/dbt-utils#792 (review).

But the integration for dbt-snowflake still isn't the way we'd like it to be ideally:

Important

It is currently not possible in dbt-snowflake to make a seed with a quoted identifier. So this PR hardcodes an uppercase identifier for Snowflake to align with that behavior. But we should update this if/when dbt-labs/dbt-adapters#178 or dbt-labs/dbt-core#2986 is implemented.

Opened #195 to address this piece separately.

Checklist

  • This code is associated with an issue which has been triaged and accepted for development.
  • I have verified that these changes work
  • I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable)

@dbeatty10 dbeatty10 changed the title Restore case sensitivity test Restore CI test for case-sensitive identifiers when generating sources Nov 19, 2024
@dbeatty10 dbeatty10 added the case_sensitivity Issues related to case-sensitivity behavior label Nov 19, 2024
@dbeatty10 dbeatty10 marked this pull request as ready for review November 19, 2024 23:53
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Nov 19, 2024
@dbeatty10 dbeatty10 merged commit 7acc8c0 into main Nov 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
case_sensitivity Issues related to case-sensitivity behavior size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[chore] fix integration tests
1 participant