Restore CI test for case-sensitive identifiers when generating sources #192
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #184
Problem
The integration test for the #168 feature was removed in https://github.com/dbt-labs/dbt-codegen/pull/174/files.
Solution
Restore the test that was removed and make updates as-needed so that it works across databases.
This was possible for dbt-redshift because in the interim, we had already updated the
enable_case_sensitive_identifier
setting totrue
in the cluster’s parameter group via the Amazon Redshift console. Backstory accessible via dbt-labs/dbt-utils#792 (review).But the integration for dbt-snowflake still isn't the way we'd like it to be ideally:
Important
It is currently not possible in dbt-snowflake to make a seed with a quoted identifier. So this PR hardcodes an uppercase identifier for Snowflake to align with that behavior. But we should update this if/when dbt-labs/dbt-adapters#178 or dbt-labs/dbt-core#2986 is implemented.
Opened #195 to address this piece separately.
Checklist