Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setuptools is needed to provide pkg_resources #31

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

AdrienPensart
Copy link
Contributor

setuptools seems to be needed in order to provide pkg_resources, this PR will fix that, so users don't need to add setuptools themselves.

@dbrgn
Copy link
Owner

dbrgn commented Jun 2, 2024

Hm, the requirement on setuptools is defined inside the call to setuptools.setup. Will this really help?

@Bilbottom
Copy link

Bilbottom commented Jul 29, 2024

This also impacts me so I'm in favour of this PR

I use Poetry for package management and installing the dependencies doesn't include setuptools, presumably because Poetry uses a different build backend


  • Operating system: Windows 10
  • Python version: 3.11.5
  • coverage-badge version: 1.1.1
  • Poetry version: 1.8.0
    • Build backend: poetry.core.masonry.api

@dbrgn
Copy link
Owner

dbrgn commented Aug 2, 2024

Again: The requirement on setuptools is defined inside the call to setuptools.setup. Will this really help?

To me, it looks like the PR won't actually solve the issue.

@Bilbottom
Copy link

Bilbottom commented Aug 2, 2024

Again: The requirement on setuptools is defined inside the call to setuptools.setup. Will this really help?

To me, it looks like the PR won't actually solve the issue.

From what I can see, the setuptools package isn't defined as a requirement in the setup call -- that's what this PR is going to do 😅

In my case, Poetry doesn't need setuptools so it won't install it unless it's explicitly added as a dependency:

image

I've "fixed" my downstream repos by adding setuptools as a dependency, but since this project assumes that setuptools is available inside the source code, this PR would ensure that setuptools exists regardless of how the package is installed by its users 🙂

@dbrgn
Copy link
Owner

dbrgn commented Aug 2, 2024

Ah, so I guess some tools don't actually evaluate the script, but will instead have their own pseudo-setuptools implementation.

I guess it doesn't hurt to include it, so I'll merge this.

@dbrgn dbrgn merged commit 12c1fa8 into dbrgn:main Aug 2, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants