Remove column dedupe fix because common not updated properly.

dbosak01 · Sep 28, 2023 · 6e80187 · 6e80187
1 parent 57b6f45
commit 6e80187
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 6 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -2,7 +2,6 @@
 
 * Added example for page breaking.
 * Added _columns_ parameter to `footnotes()` function.
-* Fixed column dedupe functionality to account for non-unique values.
 * Allow user to put new line in page-by column value.
 * Remove message on page-by sort.
 * Fixed character escape on DOCX.

diff --git a/R/utilities.R b/R/utilities.R
@@ -881,7 +881,10 @@ dedupe_pages <- function(pgs, defs) {
           w <- min(nchar(dat[[def$var_c]])) # Take min to exclude label row
           v <- paste0(rep(" ", times = w), collapse = "")
 
-          dat[[def$var_c]] <- ifelse(changed(dat[[def$var_c]]), 
+          # dat[[def$var_c]] <- ifelse(changed(dat[[def$var_c]]), 
+          #                            dat[[def$var_c]], v) 
+
+          dat[[def$var_c]] <- ifelse(!duplicated(dat[[def$var_c]]), 
                                      dat[[def$var_c]], v) 
         }
       }

diff --git a/docs/news/index.html b/docs/news/index.html
diff --git a/docs/pkgdown.yml b/docs/pkgdown.yml
@@ -19,7 +19,7 @@ articles:
   reporter-title_header: reporter-title_header.html
   reporter-wrap: reporter-wrap.html
   reporter: reporter.html
-last_built: 2023-09-28T03:23Z
+last_built: 2023-09-28T06:08Z
 urls:
   reference: https://reporter.r-sassy.org/reference
   article: https://reporter.r-sassy.org/articles

diff --git a/docs/reference/create_plot.html b/docs/reference/create_plot.html
diff --git a/tests/testthat/Rplots.pdf b/tests/testthat/Rplots.pdf