Skip to content
This repository has been archived by the owner on Sep 21, 2023. It is now read-only.

remove unnecessary itemprops #998

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

remove unnecessary itemprops #998

wants to merge 5 commits into from

Conversation

evoX0
Copy link
Contributor

@evoX0 evoX0 commented Feb 28, 2019

No description provided.

@evoX0 evoX0 requested a review from misund February 28, 2019 13:52
misund
misund suggested changes Mar 5, 2019
View reviewed changes
Copy link
Contributor

@misund misund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since we use JSON LD schema, itemprop author is duplicating it

This would mean that we expect everything that uses shiny to use JSON LD schema. In my opinion, the LD schema should be the one to go first if there's a conflict.

evoX0 added 2 commits March 6, 2019 10:26
@evoX0
add bool noSchema
e22548a 
by default we still use itemprop
@evoX0
Merge remote-tracking branch 'origin/fix/duplicating-jsonld-schema' i…
ac59c0c 
…nto fix/duplicating-jsonld-schema
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@misund misund misund requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evoX0 @misund