feature(KickerSection): Introduce Kicker Section #831
Conversation
misund
changed the title
misund
force-pushed
the
feature/kicker-section
branch
from
69ddc32 to
d415950
Compare
misund
force-pushed
the
feature/kicker-section
branch
from
531db7c to
b6cf719
Compare
| alt={title} | ||
| ratio={ratio} | ||
| offset={offset} | ||
| src={placeholderUrl ? placeholderUrl : image} | ||
| preventBlur={preventBlur} | ||
| fadeIn={fadeIn} | ||
| > | ||
| {displayPlayIcon && <PlayIcon />} |
There was a problem hiding this comment.
It would be nice to have a color prop for icon
There was a problem hiding this comment.
PlayIcon will pass props along to SvgIcon
|
|
||
| import { OverlayingPlugLabel } from '../atoms/OverlayingPlugLabel'; | ||
|
|
||
| const Footer = styled.footer` |
There was a problem hiding this comment.
I needed an enclosing element to avoid individual labels taking part in the PlugLink's column-direction flex – if they did, they would fill the entire width of the plug. The PlugLink's column-direction flex is there to give us the the order attribute. When adding the extra element anyways, we might as well try to add some semantics.
The footer element represents a footer for its nearest ancestor sectioning content or sectioning root element.
☝️ HTML spec. It's nearest ancestor sectioning content would be our <article> element.
A footer typically contains information about its section such as who wrote it, links to related documents, copyright data, and the like.
Basically, a <footer> is a good place to put metadata that does not go in a <header>.
This browser will be used to create the screenshots that will be tested in our visual regression tests on Percy.
Work in progress
This PR contains several features, and should probably be rebased onto master instead of squashed.
Please tick a box
If you're adding a feature, is it documented in a storybook story?
Are the components you're working on reusable between brands?
If you're creating markup, did you add proper semantics?
(Did you do a CR and see that there is something that we should check for each PR, that are not on the list, please update this document)