fix(AdSettingsCog + SvgIconWrapper): Changed cogwheel and svgIconWrapper type

[AmerSharif]

AdSettingsCog: Changed from div to button because of wcag2 feedback
SvgIconWrapper: Changed from div to span to avoid having a block element inside button.

Please tick a box

• feature (A new feature)
• fix (A bug fix)
• refactor (A code change that neither fixes a bug nor adds a feature)
• docs (Documentation only changes)
• performance (A code change that improves performance)
• style (Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc))
• build (Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm))
• ci (Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs))
• test (Adding missing tests or correcting existing tests)

If you're adding a feature, is it documented in a storybook story?

• Yes
• No
• Not adding a new feature

Are the components you're working on reusable between brands?

• Yes (Using variables that are defined in the default theme)
• No (I hard coded some values)
• Not working on any components

If you're creating markup, did you add proper semantics?

• I added ARIA attributes
• I added microdata from Schema.org
• Semantics are derived from HTML
• Not applicable

(Did you do a CR and see that there is something that we should check for each PR, that are not on the list, please update this document)

[misund]

The changes in AdSettingsCog are fine. Is there a reason for the wrapper change? The largest difference between a div and a span is the initial display-property.

[misund]

Why this change?

[AmerSharif]

Changed SvgIconWrapper to avoid putting a div (block element) inside a button element. Best practice i think :S Should i avoid doing it?