Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: support specta 2 #48

Merged
merged 10 commits into from
Apr 9, 2024
Merged

Conversation

brainbicycle
Copy link
Collaborator

@brainbicycle brainbicycle commented Apr 3, 2024

👋

  • updates the podspec to support latest version of Specta
  • changes to xcodeproj due to later cocoapods version

The tests in the example project are passing with these changes but let me know if any other tests or changes are needed!
Thanks for the library!

@@ -213,7 +213,6 @@
A24E011B17F9A42A001252DB /* Frameworks */,
A24E011C17F9A42A001252DB /* Resources */,
279D0DCE5C316DE54BD5FF49 /* [CP] Embed Pods Frameworks */,
F04559B5D97B33B48486C223 /* [CP] Copy Pods Resources */,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

believe most of these changes are due to cocoapods version update + updating minimum deployment target but let me know if needs cleanup

Gemfile Outdated Show resolved Hide resolved
@dblock
Copy link
Owner

dblock commented Apr 4, 2024

I love it! Haven't touched this project in a long time, but would be glad to revive it (and welcome a new maintainer :)). Let's replace Travis-CI by GHA first to get CI/CD working again? Want to PR that separately?

@brainbicycle
Copy link
Collaborator Author

I love it! Haven't touched this project in a long time, but would be glad to revive it (and welcome a new maintainer :)). Let's replace Travis-CI by GHA first to get CI/CD working again? Want to PR that separately?

hey! sure I can take a stab at that, can't promise too much bandwidth but happy to help where I can.

@dblock
Copy link
Owner

dblock commented Apr 5, 2024

I love it! Haven't touched this project in a long time, but would be glad to revive it (and welcome a new maintainer :)). Let's replace Travis-CI by GHA first to get CI/CD working again? Want to PR that separately?

hey! sure I can take a stab at that, can't promise too much bandwidth but happy to help where I can.

Great. LMK if you are not working on (re)adding CI and I can try to find time.

@dblock
Copy link
Owner

dblock commented Apr 8, 2024

Merged #49, want to rebase this one? Update CHANGELOG/README?

@brainbicycle brainbicycle force-pushed the brian/support-specta-2 branch from ec99f99 to 33b4b4c Compare April 8, 2024 20:01
@dblock dblock merged commit 7f99f90 into dblock:master Apr 9, 2024
1 check passed
@dblock
Copy link
Owner

dblock commented Apr 9, 2024

@brainbicycle Thanks! Want to come join as a maintainer of this project? I haven't worked on it in years and I'm glad someone is using it.

@brainbicycle
Copy link
Collaborator Author

@brainbicycle Thanks! Want to come join as a maintainer of this project? I haven't worked on it in years and I'm glad someone is using it.

hey sure, thanks for asking! Will help where I can.

@dblock
Copy link
Owner

dblock commented Apr 9, 2024

Added, https://github.com/dblock/ios-snapshot-test-case-expecta/invitations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants