-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: support specta 2 #48
Conversation
@@ -213,7 +213,6 @@ | |||
A24E011B17F9A42A001252DB /* Frameworks */, | |||
A24E011C17F9A42A001252DB /* Resources */, | |||
279D0DCE5C316DE54BD5FF49 /* [CP] Embed Pods Frameworks */, | |||
F04559B5D97B33B48486C223 /* [CP] Copy Pods Resources */, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
believe most of these changes are due to cocoapods version update + updating minimum deployment target but let me know if needs cleanup
FBSnapshotTestCaseDemo/FBSnapshotTestCaseDemoTests/FBSnapshotTestCaseDemoSpecs.m
Outdated
Show resolved
Hide resolved
I love it! Haven't touched this project in a long time, but would be glad to revive it (and welcome a new maintainer :)). Let's replace Travis-CI by GHA first to get CI/CD working again? Want to PR that separately? |
hey! sure I can take a stab at that, can't promise too much bandwidth but happy to help where I can. |
Great. LMK if you are not working on (re)adding CI and I can try to find time. |
Merged #49, want to rebase this one? Update CHANGELOG/README? |
ec99f99
to
33b4b4c
Compare
@brainbicycle Thanks! Want to come join as a maintainer of this project? I haven't worked on it in years and I'm glad someone is using it. |
hey sure, thanks for asking! Will help where I can. |
👋
The tests in the example project are passing with these changes but let me know if any other tests or changes are needed!
Thanks for the library!