Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll for the table in SQL View #30

Merged
merged 1 commit into from
Dec 5, 2021

Conversation

kaushikprasanth
Copy link
Contributor

This Pull request fixes Issue #26

SQLExecutor component width was not defined previously. Now the width is defined as (100vw -348px [3rem sidebar + 300px Query History Pane]). Also, the Query Textarea height has been reduced to 1/3 for a larger table view.

Screenshot after the changes:

93a72784-f388-4d52-ada5-2aaed50ac262

2703bbbf-6a31-48ba-8d7b-e4787c25e6f6

Copy link
Collaborator

@soorajshankar soorajshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
Thanks @kaushikprasanth for contributing! 🎉

@soorajshankar soorajshankar merged commit 1037978 into dblens:main Dec 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants