eliminate unnecessary SHOW TABLES which breaks on Vitess

dbcli · Dec 11, 2024 · 4b77930 · 4b77930
1 parent 38b886e
commit 4b77930
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/mycli/completion_refresher.py b/mycli/completion_refresher.py
@@ -114,8 +114,9 @@ def refresh_schemata(completer, executor):
 
 @refresher("tables")
 def refresh_tables(completer, executor):
-    completer.extend_relations(executor.tables(), kind="tables")
-    completer.extend_columns(executor.table_columns(), kind="tables")
+    table_columns_dbresult = list(executor.table_columns())
+    completer.extend_relations(table_columns_dbresult, kind="tables")
+    completer.extend_columns(table_columns_dbresult, kind="tables")
 
 
 @refresher("users")

diff --git a/mycli/sqlcompleter.py b/mycli/sqlcompleter.py
@@ -1010,6 +1010,9 @@ def extend_columns(self, column_data, kind):
 
         metadata = self.dbmetadata[kind]
         for relname, column in column_data:
+            if relname not in metadata[self.dbname]:
+                _logger.error("relname '%s' was not found in db '%s'", relname, self.dbname)
+                continue
             metadata[self.dbname][relname].append(column)
             self.all_completions.add(column)