-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switched to pipnest package structure #5
base: master
Are you sure you want to change the base?
Conversation
In this way, previous standar cmake installation will not work? It is good to have |
Standard CMake installation still works, maybe with some adaptations to the instructions with regards to the directory instructions like |
Aaaaah no I see what you mean, you should always freeze your dependencies in notebooks and other "deployments":
Otherwise when any of your dependencies change your notebook breaks. Is there anything that you know of for SGA2 review that depends on this? If so we will wait until it's passed to change this. You could also go to these deployments and just appends a commit SHA to the clone command. |
I would not let BSP notebooks to break even after SGA2 review..they could still be used for educational purposes, dissemination etc..If at all, we could make them compatible to the new cerebnest when they also adapt them to the new eBRAINS platform. |
Ok, if they need to function in perpetuity the dependencies need to be frozen, there's no way around that. |
After tons of messing with Travis and NEST I think I've got to an agreeable situation:
All that's left to do now is to reattach the CMake install instructions to the README |
@alberto-antonietti @AliceGem could you take another look to see if you like the PR now? Could you also test the pip package with |
@AliceGem maybe update the information in |
With this structure we should be able to package this module as a pip package using
And can be installed with