refactor: Use go-git for cmd/l #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ports the `l` command to use go-git rather than git4go as go-git is better supported and supports Go modules. Fixes dayvonjersen#14 Signed-off-by: Ian Lewis <[email protected]>
Moves the submodule for GitHub's `linguist` to a `third_party` subdirectory and adds an empty `go.mod` to it. This prevents `go.mod` run on this project from reading into third party submodules when searching for Go dependencies. Signed-off-by: Ian Lewis <[email protected]>
ianlewis
force-pushed
the
14-go-mod-tidy
branch
from
57b0292
to
76aac37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports the
lcommand to use go-git rather than git4go as go-git isbetter supported and supports Go modules.
Also moves the submodule for GitHub's
linguistto athird_partysubdirectory and adds an empty
go.modto it. This preventsgo.modrun on this project from reading into third party submoduleswhen searching for Go dependencies.
Fixes #14