Merge pull request #34 from davidecaruso/increase-coverage

Increase code coverage
davidecaruso · Sep 4, 2022 · d4c5e19 · d4c5e19
2 parents 2c6caa7 + 956b88e
commit d4c5e19
Show file tree

Hide file tree

Showing 6 changed files with 53 additions and 2 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "shell.js",
-  "version": "4.3.0",
+  "version": "4.3.1",
   "description": "A JavaScript library to create HTML terminals in web pages.",
   "author": "Davide Caruso <[email protected]>",
   "homepage": "https://shelljs.io",

diff --git a/src/Classes.test.ts b/src/Classes.test.ts
@@ -47,6 +47,15 @@ describe('Classes', () => {
                 expect(
                     buildClasses({ engine: 'ubuntu', theme: 'light', shadow: false, responsive: true })('')
                 ).to.be.deep.equal('shell shell--ubuntu shell--light shell--responsive')
+                expect(
+                    buildClasses({
+                        typing: { ctor: Object },
+                        engine: 'ubuntu',
+                        theme: 'light',
+                        shadow: false,
+                        responsive: true,
+                    })('')
+                ).to.be.deep.equal('shell shell--ubuntu shell--light shell--responsive shell--typed')
             })
         })
         describe('with current classes', () => {
@@ -66,6 +75,15 @@ describe('Classes', () => {
                 expect(
                     buildClasses({ engine: 'ubuntu', theme: 'light', shadow: false, responsive: true })('foo bar baz')
                 ).to.be.deep.equal('foo bar baz shell shell--ubuntu shell--light shell--responsive')
+                expect(
+                    buildClasses({
+                        typing: { ctor: Object },
+                        engine: 'ubuntu',
+                        theme: 'light',
+                        shadow: false,
+                        responsive: true,
+                    })('foo bar baz')
+                ).to.be.deep.equal('foo bar baz shell shell--ubuntu shell--light shell--responsive shell--typed')
             })
         })
     })

diff --git a/src/Command.test.ts b/src/Command.test.ts
@@ -153,6 +153,12 @@ describe('Command', () => {
                     )
                 })
             })
+            describe('with root user', () => {
+                const config: Config = { ...defaultConfig, root: true }
+                it('should not print anything', () => {
+                    expect(exec(input(config)('sudo -i'))).to.be.deep.equal(undefined)
+                })
+            })
         })
 
         describe('exit', () => {

diff --git a/src/Config.test.ts b/src/Config.test.ts
@@ -1,5 +1,6 @@
 import { expect } from 'chai'
 import {
+    buildConfig,
     defaultConfig,
     hasShadow,
     isDefault,
@@ -92,4 +93,26 @@ describe('Config', () => {
             expect(hasShadow({ shadow: true })).to.be.true
         })
     })
+
+    describe('buildConfig', () => {
+        it('should return built config', () => {
+            expect(buildConfig({})).to.be.deep.equal(defaultConfig)
+            expect(buildConfig({ engine: 'macos' })).to.be.deep.equal({ ...defaultConfig, engine: 'macos', path: '~' })
+            expect(buildConfig({ engine: 'ubuntu' })).to.be.deep.equal({
+                ...defaultConfig,
+                engine: 'ubuntu',
+                path: '~',
+            })
+            expect(buildConfig({ engine: 'default' })).to.be.deep.equal({
+                ...defaultConfig,
+                engine: 'default',
+                path: '~',
+            })
+            expect(buildConfig({ engine: 'windows' })).to.be.deep.equal({
+                ...defaultConfig,
+                engine: 'windows',
+                path: 'C:\\Windows\\system32\\',
+            })
+        })
+    })
 })
diff --git a/src/Content.test.ts b/src/Content.test.ts
@@ -8,21 +8,25 @@ describe('Content', () => {
         describe('with "ubuntu" engine', () => {
             it('should return empty string', () => {
                 expect(login({ ...defaultConfig, engine: 'ubuntu' })(date)).to.be.deep.equal('')
+                expect(login({ ...defaultConfig, engine: 'ubuntu' })()).to.be.deep.equal('')
             })
         })
         describe('with "windows" engine', () => {
             it('should return empty string', () => {
                 expect(login({ ...defaultConfig, engine: 'windows' })(date)).to.be.deep.equal('')
+                expect(login({ ...defaultConfig, engine: 'windows' })()).to.be.deep.equal('')
             })
         })
         describe('with "default" engine', () => {
             it('should return empty string', () => {
                 expect(login({ ...defaultConfig, engine: 'default' })(date)).to.be.deep.equal('')
+                expect(login({ ...defaultConfig, engine: 'default' })()).to.be.deep.equal('')
             })
         })
         describe('with "macos" engine', () => {
             it('should return login string', () => {
                 expect(login({ ...defaultConfig, engine: 'macos' })(date)).to.be.not.equal('')
+                expect(login({ ...defaultConfig, engine: 'macos' })()).to.be.not.equal('')
             })
         })
     })

diff --git a/src/Content.ts b/src/Content.ts
@@ -15,7 +15,7 @@ import { Config, isMacOs, isRoot, isWindows } from './Config'
 const prefix = ({ context }: Pick<IO, 'context'>): string =>
     `<span class="${linePrefixClass}">` +
     (isWindows(context)
-        ? `<span class="path">${context.path}</span>` + `<span class="char">${isRoot(context) ? '#' : '&gt;'}</span>`
+        ? `<span class="path">${context.path}</span><span class="char">&gt;</span>`
         : `<span class="user">${isRoot(context) ? 'root' : context.user}@</span>` +
           `<span class="host">${context.host}</span>` +
           `<span class="colon">:</span>` +