Support vips 8.16.0 #455
Merged
Support vips 8.16.0 #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This removes the usage of the deprecated VIPS_FOREIGN_JPEG_SUBSAMPLE enum, instead using the VIPS_FOREIGN_SUBSAMPLE_ON enum in it's place
|
@davidbyttow I dunno if you're still active on this repo, but I'm wondering if you could give this a quick review / merge? I have compiled with this patch successfully. |
|
hi @mholt sure, but did you look into the build failure? is it related? |
|
i guess i'd ask @cdimitroulas the same thing |
|
n/m, i see it failing here too https://github.com/davidbyttow/govips/actions/runs/11936217005/job/34418567726?pr=456 |
|
(Oh, sorry -- no, I did not look into the build failures. But I just know that my application is working with it. Probably not as solid an indicator as a proper test suite though 😄 ) Thanks for the merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the usage of the deprecated
VipsForeignJpegSubsampleenum, instead using the VipsForeignSubsample enum in it's place.I have very limited understanding about C, header files and CGo, so apologies if this implementation is way off the mark.
Closes #453