Query current logger instead of global one (should fix #92) #101
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently fitting a GMM produces a lot of output:
Part of this output can't be easily suppressed (see #92) because this code queries the global logger:
GaussianMixtures.jl/src/train.jl
Line 103 in 9926a11
For example, this makes estimating thousands of small GMMs extremely noisy, and the only solution to silence logging seems to involve changing the global logger which isn't ideal.
Possible solution
Query the current logger instead using
Logging.current_logger()
, which returns either the "task-local" logger or the global one if there's no local logger.This should let users change the logger and suppress logging entirely: