Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Traefik IPWhiteList deprecated - Use IPAllowList Instead #719

Merged
merged 7 commits into from
Aug 16, 2024

Conversation

nickjones33
Copy link
Contributor

What this PR does / why we need it:
Updates references from the deprecated IPWhiteList Traefik middleware to use IPAllowlist instead, so that we don't get deprecation warnings from Traefik

Which issue (if any) this PR fixes:

Fixes #703

Any other useful info:

@nickjones33
Copy link
Contributor Author

I'm not super familiar with the typical github and/or ansible-nas-specific PR process so please let me know if I need to make any changes here, I will monitor this PR and respond to feedback accordingly.

I noticed Issue #703 sitting out there and figured I could make a PR pretty quickly for it

Copy link
Owner

@davestephens davestephens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good change, thank you.

It has been implemented in a way that will break people with no warning though - please can you add a check for the *whitelist variables being set in the relevant roles, and throw an error if so? You'll find equivalent checks for variables in Drone role, if you need something to use as a reference.

@nickjones33
Copy link
Contributor Author

Thanks for the Drone role example, I hope I've followed it as you expected. I set default values in the *whitelist variables of "deprecated" and threw the builtin.fail if the setting had been changed.

@davestephens
Copy link
Owner

Thanks - getting there! You should be able to use is defined rather than check for specific content of the variable. This will enable removing of the *whitelist variables from the variables now, leaving only the check you've put in as the remnants of any *whitelist stuff.

@nickjones33
Copy link
Contributor Author

That makes much more sense!

@davestephens davestephens merged commit 2151f62 into davestephens:main Aug 16, 2024
3 checks passed
@davestephens
Copy link
Owner

Awesome, thank you! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Traefik IPWhiteList deprecated - IPAllowList
2 participants