Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for the other 4 exif orientations #384

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

jkmcnk
Copy link

@jkmcnk jkmcnk commented Jan 19, 2018

I added support for the yet unsupported exif orientations: flip {h,v}, trans{pose,verse}. thought I might as well contribute something back. so, here's the relevant code for your consideration.

you can test it with the exif orientation sample dataset here: http://k00.fr/kvfvy

best, j

jkmcnk and others added 2 commits January 19, 2018 11:41
Support the other 4 exif orientations.
@davemorrissey
Copy link
Owner

Looks interesting, did you do this because you needed the feature? Until now I don't think anyone had asked for it. It'll need some thorough testing which I don't have time for at the moment but I'll come back to it.

@jkmcnk
Copy link
Author

jkmcnk commented Jan 24, 2018

yes. as far as testing goes, it was (and is being) tested with and without tiling, in a pan and zoom setting, in the android client for our storage service on a variety of devices, but I do suppose a more systematic approach to testing would be nice. ;) anyhow, glad to fix any issues that might arise.

@davemorrissey
Copy link
Owner

I don't plan to merge this but I'll leave this PR open so others can use this branch if they need this support.

Copy link

@perracodex perracodex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this pull request for all possible Exif orientations, and image rendering works correctly, but panning fails for flip vertical / horizontal, transpose, and transverse.
The issue is in the onFling callback, the velocities should be inverted + adjusted for these cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants