Apply suggestions from code review

Co-authored-by: Junhao Liao <[email protected]>
davemarco · Sep 15, 2024 · f09580e · f09580e
1 parent ed48751
commit f09580e
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 6 deletions.
diff --git a/new-log-viewer/src/components/Layout.tsx b/new-log-viewer/src/components/Layout.tsx
@@ -14,9 +14,6 @@ import APP_THEME from "./theme";
  *
  * @return
  */
-// eslint-disable-next-line no-warning-comments
-// TODO: replace elements in this component once we integrate with a UI framework
-// eslint-disable-next-line max-lines-per-function
 const Layout = () => {
     return (
         <CssVarsProvider

diff --git a/new-log-viewer/src/components/StatusBar/LogLevelFilter.tsx b/new-log-viewer/src/components/StatusBar/LogLevelFilter.tsx
@@ -42,8 +42,6 @@ const LogLevelSelect = () => {
         const selected: LogLevelFilter =
       newValue && newValue.map((value) => Number(value));
 
-        console.log(newValue);
-
         setSelectedLogLevels(selected);
         changeLogLevelFilter(selected);
     };

diff --git a/new-log-viewer/src/typings/worker.ts b/new-log-viewer/src/typings/worker.ts
@@ -85,8 +85,8 @@ type WorkerRespMap = {
     },
     [WORKER_RESP_CODE.VIEW_INFO]: {
         firstLogEventNumPerPage: number[],
-        numFilteredEvents: number,
         lastLogEventNumPerPage: number[],
+        numFilteredEvents: number,
     }
 };