Skip to content

Commit

Permalink
fix eslint
Browse files Browse the repository at this point in the history
  • Loading branch information
davemarco committed Sep 6, 2024
1 parent 634c429 commit 8699154
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 6 deletions.
4 changes: 2 additions & 2 deletions new-log-viewer/src/services/LogFileManager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ class LogFileManager {
this.#numFilteredEvents = filteredLogEventsIndices.length;

for (let i = 0; i < this.#numFilteredEvents; i += this.#pageSize) {
let firstLogEventOnPageIdx: number = filteredLogEventsIndices[i] as number
const firstLogEventOnPageIdx: number = filteredLogEventsIndices[i] as number
this.#firstLogEventNumPerPage.push(1 + firstLogEventOnPageIdx);

Check failure on line 245 in new-log-viewer/src/services/LogFileManager.ts

View workflow job for this annotation

GitHub Actions / ESLint Report Analysis

new-log-viewer/src/services/LogFileManager.ts#L244-L245

[@stylistic/js/semi] Missing semicolon.

//Need to minus one from page size to get correct index into filtered log events.

Check failure on line 247 in new-log-viewer/src/services/LogFileManager.ts

View workflow job for this annotation

GitHub Actions / ESLint Report Analysis

new-log-viewer/src/services/LogFileManager.ts#L247

[@stylistic/js/spaced-comment] Expected space or tab after '//' in comment.
Expand All @@ -252,7 +252,7 @@ class LogFileManager {
lastPageIdx = this.#numFilteredEvents - 1
}

Check failure on line 253 in new-log-viewer/src/services/LogFileManager.ts

View workflow job for this annotation

GitHub Actions / ESLint Report Analysis

new-log-viewer/src/services/LogFileManager.ts#L252-L253

[@stylistic/js/semi] Missing semicolon.

let lastLogEventOnPageIdx: number = filteredLogEventsIndices[lastPageIdx] as number
const lastLogEventOnPageIdx: number = filteredLogEventsIndices[lastPageIdx] as number
this.#lastLogEventNumPerPage.push(1 + lastLogEventOnPageIdx);

Check failure on line 256 in new-log-viewer/src/services/LogFileManager.ts

View workflow job for this annotation

GitHub Actions / ESLint Report Analysis

new-log-viewer/src/services/LogFileManager.ts#L255-L256

[@stylistic/js/semi] Missing semicolon.
}
}
Expand Down
4 changes: 1 addition & 3 deletions new-log-viewer/src/services/decoders/ClpIrDecoder.ts
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
import clpFfiJsModuleInit, {ClpIrStreamReader} from "clp-ffi-js";

import {Nullable} from "../../typings/common";
import {
LogLevelFilter
} from "../../typings/logs";

import {
Decoder,
DecodeResultType,
Expand Down
2 changes: 1 addition & 1 deletion new-log-viewer/src/services/decoders/JsonlDecoder.ts
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ class JsonlDecoder implements Decoder {
* @return Array with indices as values (i.e [0, 1, 2, 3, ..., length - 1])
*/
#createIndicesArray (length: number): number[] {

Check failure on line 210 in new-log-viewer/src/services/decoders/JsonlDecoder.ts

View workflow job for this annotation

GitHub Actions / ESLint Report Analysis

new-log-viewer/src/services/decoders/JsonlDecoder.ts#L210

[class-methods-use-this] Expected 'this' to be used by class private method #createIndicesArray.
let filteredLogIndices: number[] = Array.from(
const filteredLogIndices: number[] = Array.from(

Check failure on line 211 in new-log-viewer/src/services/decoders/JsonlDecoder.ts

View workflow job for this annotation

GitHub Actions / ESLint Report Analysis

new-log-viewer/src/services/decoders/JsonlDecoder.ts#L211

[@stylistic/js/no-multi-spaces] Multiple spaces found before '='.
{length: length},
(_, index) => index
);
Expand Down

0 comments on commit 8699154

Please sign in to comment.