cleaning

davemarco · Sep 19, 2024 · 64a3f7a · 64a3f7a
1 parent b70bdb6
commit 64a3f7a
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 21 deletions.
diff --git a/new-log-viewer/src/services/LogFileManager.ts b/new-log-viewer/src/services/LogFileManager.ts
@@ -223,7 +223,8 @@ class LogFileManager {
         const result: boolean = this.#decoder.changeLogLevelFilter(logLevelFilter);
 
         if (false === result) {
-            throw new Error("Error changing log level filter");
+            throw new Error(`Error changing log level filter as feature not yet
+                implemented for this file type on new log viewer`);
         }
 
         logLevelFilter ? this.#computeFilteredPageBoundaries() : this.#computeUnfilteredPageBoundaries()

diff --git a/new-log-viewer/src/services/MainWorker.ts b/new-log-viewer/src/services/MainWorker.ts
@@ -80,6 +80,7 @@ onmessage = async (ev: MessageEvent<MainWorkerReqMessage>) => {
                     throw new Error("Log file manager hasn't been initialized");
                 }
                 LOG_FILE_MANAGER.changeLogLevelFilter(args.logLevelFilter);
+
                 postResp(WORKER_RESP_CODE.VIEW_INFO, {
                     numFilteredEvents: LOG_FILE_MANAGER.numFilteredEvents,
                     firstLogEventNumPerPage: LOG_FILE_MANAGER.firstLogEventNumPerPage,

diff --git a/new-log-viewer/src/services/decoders/ClpIrDecoder.ts b/new-log-viewer/src/services/decoders/ClpIrDecoder.ts
@@ -49,10 +49,14 @@ class ClpIrDecoder implements Decoder {
     changeLogLevelFilter (logLevelFilter: LogLevelFilter): boolean {
         // eslint-disable-next-line no-warning-comments
         // TODO fix this after log level filtering is implemented in clp-ffi-js
-        return true;
+        return false;
     }
 
-    decode (beginIdx: number, endIdx: number): Nullable<DecodeResultType[]> {
+    decodeRange (beginIdx: number, endIdx: number): Nullable<DecodeResultType[]> {
+        return this.#streamReader.decodeRange(beginIdx, endIdx);
+    }
+
+    decodeFilteredRange (beginIdx: number, endIdx: number): Nullable<DecodeResultType[]> {
         return this.#streamReader.decodeRange(beginIdx, endIdx);
     }
 }

diff --git a/new-log-viewer/src/services/decoders/JsonlDecoder.ts b/new-log-viewer/src/services/decoders/JsonlDecoder.ts
@@ -20,24 +20,6 @@ import {
     LogLevelFilter,
 } from "../../typings/logs";
 import LogbackFormatter from "../formatters/LogbackFormatter";
-import { number } from "prop-types";
-
-
-/**
- * Set the default log level filter (i.e. all levels are selected, so the array should include all
- * log indices).
- *
- * @param length
- * @return Array with indices as values (i.e [0, 1, 2, 3, ..., length - 1])
- */
-const createIndicesArray = (length: number): number[] => {
-    const LogIndices: number[] = Array.from(
-        {length: length},
-        (_, index) => index
-    );
-
-    return LogIndices;
-};
 
 /**
  * A decoder for JSONL (JSON lines) files that contain log events. See `JsonlDecodeOptionsType` for