Add error alerts for folder_with_pdbs .pdb error #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: If the folder_with_pdbs variable in the submission script for a fixed residues run was set to equal the path of a pdb rather than a folder containing pdb's, the full program would run without having any files to run on and without alerting the user to the nature of the problem. This made identifying the lack of output difficult. Previous handling: None New handling: Detect ".pdb" in variable name and output "The fixed positions options require a folder with pdb's be passed in, not a pdb filename. Please rectifiy the "folder_with_pdbs" variable in your submission script." to the terminal. Justification for handling choices: Rather than make a large change that could have unintended consequences downstream of the variable, an error alert to the user will assist in directing them how to properly use the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
If the folder_with_pdbs variable in the submission script for a fixed residues run was set to equal the path of a pdb rather than a folder containing pdb's, the full program would run without having any files to run on and without alerting the user to the nature of the problem. This made identifying the lack of output difficult.
Previous handling:
None
New handling:
Detect ".pdb" in variable name and output "The fixed positions options require a folder with pdb's be passed in, not a pdb filename. Please rectifiy the "folder_with_pdbs" variable in your submission script." to the terminal.
Justification for handling choices:
Rather than make a large change that could have unintended consequences downstream of the variable, an error alert to the user will assist in directing them how to properly use the code.