remove expect panics and return error instead

dathere · Oct 10, 2022 · 6539764 · 6539764
1 parent 2e74397
commit 6539764
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 6 deletions.
diff --git a/src/cmd/enumerate.rs b/src/cmd/enumerate.rs
@@ -99,8 +99,10 @@ pub fn run(argv: &[&str]) -> CliResult<()> {
         } else if args.flag_constant.is_some() {
             headers.push_field(b"constant");
         } else if copy_operation {
-            let current_header = String::from_utf8(headers[copy_index].to_vec())
-                .expect("Could not parse cell as utf-8!");
+            let current_header = match String::from_utf8(headers[copy_index].to_vec()) {
+                Ok(s) => s,
+                Err(e) => return fail_format!("Could not parse cell as utf-8! - {e}"),
+            };
             headers.push_field(format!("{current_header}_copy").as_bytes());
         } else {
             headers.push_field(b"index");

diff --git a/src/cmd/fetch.rs b/src/cmd/fetch.rs
@@ -621,8 +621,10 @@ pub fn run(argv: &[&str]) -> CliResult<()> {
             if was_cached {
                 redis_cache_hits += 1;
             }
-            final_response = serde_json::from_str(&intermediate_redis_value)
-                             .expect("Cannot deserialize Redis cache value. Try flushing the Redis cache with --flushdb.");
+            final_response = match serde_json::from_str(&intermediate_redis_value) {
+                Ok(r) => r,
+                Err(e)=> return fail_format!("Cannot deserialize Redis cache value. Try flushing the Redis cache with --flushdb - {e}"),
+            };
             if !args.flag_cache_error && final_response.status_code != 200 {
                 let key = format!(
                     "{}{:?}{}{}{}",

diff --git a/src/cmd/fetchpost.rs b/src/cmd/fetchpost.rs
@@ -585,8 +585,10 @@ pub fn run(argv: &[&str]) -> CliResult<()> {
             if was_cached {
                 redis_cache_hits += 1;
             }
-            final_response = serde_json::from_str(&intermediate_redis_value)
-                             .expect("Cannot deserialize Redis cache value. Try flushing the Redis cache with --flushdb.");
+            final_response = match serde_json::from_str(&intermediate_redis_value) {
+                Ok(r) => r,
+                Err(e)=> return fail_format!("Cannot deserialize Redis cache value. Try flushing the Redis cache with --flushdb - {e}"),
+            };
             if !args.flag_cache_error && final_response.status_code != 200 {
                 let key = format!(
                     "{}{:?}{}{}{}",