[Feature][Notification] Notification add job view link

datavane · May 21, 2024 · 11c7804 · 11c7804
1 parent 811bcc7
commit 11c7804
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/...server/src/main/java/io/datavines/server/dqc/coordinator/operator/JobResultValidator.java b/...server/src/main/java/io/datavines/server/dqc/coordinator/operator/JobResultValidator.java
@@ -128,10 +128,9 @@ private void sendErrorEmail(Long jobExecutionId) {
             String jobName;
             String dataSourceName = null;
             String dataSourceType = null;
-            String fqdn;
+            String fqdn= "";
             if (jobId == -1L) {
                 jobName = jobExecution.getName();
-                fqdn = CommonPropertyUtils.getString(CommonPropertyUtils.DATAVINES_FQDN)+"/#/main/home";
             } else {
                 JobService jobService = jobExternalService.getJobService();
                 Job job = jobService.getById(jobId);
@@ -140,7 +139,9 @@ private void sendErrorEmail(Long jobExecutionId) {
                 DataSource dataSource = jobExternalService.getDataSourceService().getDataSourceById(dataSourceId);
                 dataSourceName = dataSource.getName();
                 dataSourceType = dataSource.getType();
-                fqdn = CommonPropertyUtils.getString(CommonPropertyUtils.DATAVINES_FQDN) + String.format("/#/main/detail/%s/jobs/instance?jobId=%s", dataSourceId, jobId);
+                if (!CommonPropertyUtils.getString(CommonPropertyUtils.DATAVINES_FQDN).equals(CommonPropertyUtils.DATAVINES_FQDN_DEFAULT)) {
+                    fqdn = CommonPropertyUtils.getString(CommonPropertyUtils.DATAVINES_FQDN) + String.format("/#/main/detail/%s/jobs/instance?jobId=%s", dataSourceId, jobId);
+                }
             }
 
             List<JobExecutionResult> errorJobExecutionResultList = jobExternalService.listErrorJobExecutionResultByJobExecutionId(jobExecution.getId());