-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev/robin/8241 accumulator prove and verify #22
Merged
robinbryce
merged 18 commits into
main
from
dev/robin/8241-accumulator-prove-and-verify
Oct 30, 2024
Merged
Dev/robin/8241 accumulator prove and verify #22
robinbryce
merged 18 commits into
main
from
dev/robin/8241-accumulator-prove-and-verify
Oct 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
honourfish
reviewed
Jun 25, 2024
honourfish
reviewed
Jun 25, 2024
robinbryce
force-pushed
the
dev/robin/8241-accumulator-prove-and-verify
branch
from
September 23, 2024 10:11
2fca32c
to
a32f581
Compare
robinbryce
force-pushed
the
dev/robin/8241-accumulator-prove-and-verify
branch
from
October 27, 2024 13:14
a32f581
to
463a188
Compare
honourfish
reviewed
Oct 29, 2024
honourfish
reviewed
Oct 29, 2024
honourfish
reviewed
Oct 29, 2024
honourfish
reviewed
Oct 29, 2024
honourfish
reviewed
Oct 29, 2024
honourfish
reviewed
Oct 29, 2024
honourfish
reviewed
Oct 29, 2024
honourfish
reviewed
Oct 29, 2024
honourfish
reviewed
Oct 29, 2024
honourfish
reviewed
Oct 29, 2024
honourfish
reviewed
Oct 29, 2024
honourfish
reviewed
Oct 29, 2024
honourfish
reviewed
Oct 29, 2024
honourfish
reviewed
Oct 29, 2024
honourfish
previously approved these changes
Oct 29, 2024
Co-authored-by: Joe Gough <[email protected]> Signed-off-by: robinbryce <[email protected]>
Co-authored-by: Joe Gough <[email protected]> Signed-off-by: robinbryce <[email protected]>
Co-authored-by: Joe Gough <[email protected]> Signed-off-by: robinbryce <[email protected]>
honourfish
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MMR draft alignment changes
The primary change here is to make our consistency proofs and inclusion proofs work in terms of the accumulator defined in the paper referenced by the COSE Receipts MMRIVER draft. And generaly include full support for COSE Recieipts
It also cleans up various algorithm implementations and checks that the draft algorithm implmentations and our go lang immplementation both meet the test vectors published by the draft.
Because it remains useful to be able to do so, I have retained the original variants of algorithms that worked with mmr "bagged" peaks. Some algorithm implementations I think we can remove altogether, but in this pr have not been deleted. Instead they are used in tests which show the "old" versions match the "new" versions
So in summary
I've run all the local unit and integration tests. I've also run the integration tests in forestrie and checked that the arrangements for dealing with the change in consistency proofs work at that level. More testing for this on the forestrie side will be required before taking a release of go-datatrails-merklelog/mmr which has these changes.