Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Confirmation is now optional. #270

Merged
merged 3 commits into from
Aug 20, 2024
Merged

Confirmation is now optional. #270

merged 3 commits into from
Aug 20, 2024

Conversation

eccles
Copy link
Member

@eccles eccles commented Aug 7, 2024 •
edited
Loading

All unittests pass.

Functional tests pass with 2 changes:

  1. create an asset or event without confirmation returns JSON which is not fully populated
  2. confirmation is required it access to the publicurl is required immediately afterwards

AB#9779

@eccles eccles force-pushed the dev/paul/9779-confirmation-is-optional branch from 6bb1ef3 to c3116b8 Compare August 8, 2024 10:19
JAG-UK
JAG-UK requested changes Aug 8, 2024
View reviewed changes
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
examples/create_asset.py Outdated Show resolved Hide resolved
examples/create_event.py Outdated Show resolved Hide resolved
@eccles eccles requested a review from JAG-UK August 8, 2024 11:24
JAG-UK
JAG-UK previously approved these changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@JAG-UK JAG-UK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

JAG-UK
JAG-UK approved these changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@JAG-UK JAG-UK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LEBTM

@eccles eccles merged commit e0fd7c7 into main Aug 20, 2024
12 checks passed
@eccles eccles deleted the dev/paul/9779-confirmation-is-optional branch August 20, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JAG-UK JAG-UK JAG-UK approved these changes

@waarg waarg Awaiting requested review from waarg

@SteveLasker SteveLasker Awaiting requested review from SteveLasker

@Serhiy1 Serhiy1 Awaiting requested review from Serhiy1

@j-hartley j-hartley Awaiting requested review from j-hartley

@landintrees landintrees Awaiting requested review from landintrees

@rcoxhill-01 rcoxhill-01 Awaiting requested review from rcoxhill-01

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eccles @JAG-UK