[feat]PIP 167: Make it Configurable to Require Subscription Permission for Consumer #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eolivelli
reviewed
Apr 5, 2024
...websocket/src/main/java/org/apache/pulsar/websocket/service/WebSocketProxyConfiguration.java
Outdated
Show resolved
Hide resolved
michaeljmarshall
changed the title
|
@eolivelli @dlg99 @nicoloboschi - this is ready for review |
|
CI was failing due to invalid caching. I merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is meant to fulfill the requirements described by apache#15597.
The implementation essentially locks down all subscriptions so that in order to consume from a topic, a consumer will need permission granted for the specific topic and for the subscription within the namespace. A tenant admin and a super user will not need additional permission.