Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][broker] Cherry-pick 2.10_ds fix to block transactions in replicated namespaces #208

Merged
merged 3 commits into from
Dec 12, 2023

Conversation

nikhil-ctds
Copy link
Collaborator

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (yes)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

Check the box below or label this PR directly (if you have committer privilege).

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

(cherry picked from commit 7144b56)

 Conflicts:
	conf/broker.conf
	pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
	pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Consumer.java
	pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Producer.java
	pulsar-broker/src/test/java/org/apache/pulsar/broker/transaction/TransactionTest.java
Copy link
Collaborator

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@srinath-ctds srinath-ctds merged commit ce58e4c into 3.1_ds Dec 12, 2023
45 checks passed
@srinath-ctds srinath-ctds deleted the 3.1_ds_blk-txn branch December 12, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants