Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix][test] Trigger Workflows on 3.1_ds branch #201

Merged
merged 6 commits into from
Dec 8, 2023
Merged

[fix][test] Trigger Workflows on 3.1_ds branch #201

merged 6 commits into from
Dec 8, 2023

Conversation

nikhil-ctds
Copy link
Collaborator

@nikhil-ctds nikhil-ctds commented Dec 5, 2023 •
edited
Loading

This PR tests the workflows on 3.1_ds branch and contains the fixes for the failed tests. It includes the following changes -

  • Excludes the Build and license check.
  • Fixed incorrect groupId's in run_build_unit.sh script (CI - Unit - Other)
  • Cherry picked fix for NarUnpackerTest (CI - Unit - Other)
  • Cherry picked fix for StrategicCompactionTest.testDispatcherMaxReadSizeBytes (CI - Unit - Brokers - Client Impl)
  • Ignored PulsarSinksTest.testCassandraArchiveSink (CI - System - Pulsar IO)

Summary of the cherry picks for unit tests -
https://docs.google.com/spreadsheets/d/1D4urpSm1iQ3iY8jr2BZ7iP6FggB4DRGk/edit#gid=386183064

@nikhil-ctds nikhil-ctds self-assigned this Dec 6, 2023
@srinath-ctds srinath-ctds requested a review from zzzming December 7, 2023 11:34
eolivelli
eolivelli approved these changes Dec 7, 2023
View reviewed changes
Copy link
Collaborator

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@srinath-ctds srinath-ctds merged commit a392c2b into 3.1_ds Dec 8, 2023
53 checks passed
@srinath-ctds srinath-ctds deleted the 3.1_ds_license_check branch December 8, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eolivelli eolivelli eolivelli approved these changes

@nicoloboschi nicoloboschi Awaiting requested review from nicoloboschi

@NadirJ NadirJ Awaiting requested review from NadirJ

@zzzming zzzming Awaiting requested review from zzzming

Assignees

@nikhil-ctds nikhil-ctds

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nikhil-ctds @eolivelli @srinath-ctds @lhotari