#884 add log file count check

dataplat · Jun 1, 2022 · dbfd172 · dbfd172
1 parent 027e4cc
commit dbfd172
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 2 deletions.
diff --git a/checks/Databasev5.Tests.ps1 b/checks/Databasev5.Tests.ps1
@@ -129,4 +129,14 @@ Describe "Virtual Log Files" -Tag VirtualLogFile, Medium, Database -ForEach $Ins
             $psitem.VLF | Should -BeLessThan $psitem.ConfigValues.maxvlf -Because "Too many VLFs can impact performance and slow down backup/restore"
         }
     }
-}
+}
+
+Describe "Log File Count Checks" -Tag LogfileCount, Medium, Database -ForEach $InstancesToTest {
+    $skip = Get-DbcConfigValue skip.database.logfilecounttest
+
+    Context "Testing Log File count for <_.Name>" {
+        It "Database <_.Name> should have <_.ConfigValues.logfilecount> or less log files on <_.SqlInstance>" -Skip:$skip -ForEach $psitem.Databases.Where{ if ($Database) { $_.Name -in $Database } else { $psitem.ConfigValues.logfilecountexclude -notcontains $PsItem.Name } } {
+            $psitem.LogFileCount | Should -BeLessOrEqual $psitem.ConfigValues.logfilecount -Because "You want the correct number of log files"
+        }
+    }
+}
diff --git a/internal/configurations/configuration.ps1 b/internal/configurations/configuration.ps1
@@ -233,6 +233,7 @@ Set-PSFConfig -Module dbachecks -Name policy.asymmetrickeysize.excludedb -Value
 Set-PSFConfig -Module dbachecks -Name policy.autoclose.excludedb -Value @()  -Initialize -Description "Databases to exclude from autoclose key size checks"
 Set-PSFConfig -Module dbachecks -Name policy.autoshrink.excludedb -Value @()  -Initialize -Description "Databases to exclude from autoclose key size checks"
 Set-PSFConfig -Module dbachecks -Name policy.vlf.excludedb -Value @('master', 'msdb', 'tempdb', 'model')  -Initialize -Description "Databases to exclude from asymmetric key size checks"
+Set-PSFConfig -Module dbachecks -Name policy.logfilecount.excludedb -Value @()  -Initialize -Description "Databases to exclude from log file count checks"
 
 
 

diff --git a/internal/functions/Get-AllDatabaseInfo.ps1 b/internal/functions/Get-AllDatabaseInfo.ps1
@@ -92,7 +92,11 @@ function Get-AllDatabaseInfo {
             $ConfigValues | Add-Member -MemberType NoteProperty -Name 'maxvlf' -Value (Get-DbcConfigValue policy.database.maxvlf)
             $ConfigValues | Add-Member -MemberType NoteProperty -Name 'vlfexclude' -Value (Get-DbcConfigValue policy.vlf.excludedb)
         }
-
+        'LogFileCount' {
+            $logfilecount = $true
+            $ConfigValues | Add-Member -MemberType NoteProperty -Name 'logfilecount' -Value (Get-DbcConfigValue policy.database.logfilecount)
+            $ConfigValues | Add-Member -MemberType NoteProperty -Name 'logfilecountexclude' -Value (Get-DbcConfigValue policy.logfilecount.excludedb)
+        }
         Default { }
     }
 
@@ -116,6 +120,7 @@ function Get-AllDatabaseInfo {
                 AutoClose           = if ($autoclose) { $psitem.AutoClose}
                 AutoShrink          = if ($autoshrink) { $psitem.AutoShrink}
                 VLF                 = if ($vlf) { ($psitem.Query("DBCC LOGINFO") | Measure-Object).Count }
+                LogFileCount        = if ($logfilecount) { ($psitem.LogFiles | Measure-Object).Count }
             }
         }
     }