#884 - adding VLF.

dataplat · Jun 1, 2022 · bc2b135 · bc2b135
1 parent f4ae5db
commit bc2b135
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 0 deletions.
diff --git a/checks/Databasev5.Tests.ps1 b/checks/Databasev5.Tests.ps1
@@ -119,4 +119,14 @@ Describe "Auto Shrink" -Tag AutoShrink, High, Database -ForEach $InstancesToTest
             $psitem.AutoShrink | Should -Be $psitem.ConfigValues.autoshrink -Because "Shrinking databases causes fragmentation and performance issues"
         }
     }
+}
+
+Describe "Virtual Log Files" -Tag VirtualLogFile, Medium, Database -ForEach $InstancesToTest {
+    $skip = Get-DbcConfigValue skip.database.vlf
+
+    Context "Testing Database VLFs on <_.Name>" {
+        It "Database <_.Name> VLF count should be less than <_.ConfigValues.maxvlf> on <_.SqlInstance>" -Skip:$skip -ForEach $psitem.Databases.Where{ if ($Database) { $_.Name -in $Database } else { $psitem.ConfigValues.vlfexclude -notcontains $PsItem.Name } } {
+            $psitem.VLF | Should -BeLessThan $psitem.ConfigValues.maxvlf -Because "Too many VLFs can impact performance and slow down backup/restore"
+        }
+    }
 }
diff --git a/internal/configurations/configuration.ps1 b/internal/configurations/configuration.ps1
@@ -232,6 +232,7 @@ Set-PSFConfig -Module dbachecks -Name policy.build.behind -Value $null -Initiali
 Set-PSFConfig -Module dbachecks -Name policy.asymmetrickeysize.excludedb -Value @('master', 'msdb', 'tempdb')  -Initialize -Description "Databases to exclude from asymmetric key size checks"
 Set-PSFConfig -Module dbachecks -Name policy.autoclose.excludedb -Value @()  -Initialize -Description "Databases to exclude from autoclose key size checks"
 Set-PSFConfig -Module dbachecks -Name policy.autoshrink.excludedb -Value @()  -Initialize -Description "Databases to exclude from autoclose key size checks"
+Set-PSFConfig -Module dbachecks -Name policy.vlf.excludedb -Value @('master', 'msdb', 'tempdb', 'model')  -Initialize -Description "Databases to exclude from asymmetric key size checks"
 
 
 
@@ -258,6 +259,7 @@ Set-PSFConfig -Module dbachecks -Name skip.database.invaliddatabaseowner -Valida
 Set-PSFConfig -Module dbachecks -Name skip.database.databasecollation -Validation bool -Value $false -Initialize -Description "Skip the database collation test"
 Set-PSFConfig -Module dbachecks -Name skip.database.suspectpage -Validation bool -Value $false -Initialize -Description "Skip the suspect pages test"
 Set-PSFConfig -Module dbachecks -Name skip.database.autoclose -Validation bool -Value $false -Initialize -Description "Skip the autoclose test"
+Set-PSFConfig -Module dbachecks -Name skip.database.vlf -Validation bool -Value $false -Initialize -Description "Skip the virtual log file test"
 
 
 Set-PSFConfig -Module dbachecks -Name skip.logshiptesting -Validation bool -Value $false -Initialize -Description "Skip the logshipping test"

diff --git a/internal/functions/Get-AllDatabaseInfo.ps1 b/internal/functions/Get-AllDatabaseInfo.ps1
@@ -87,6 +87,11 @@ function Get-AllDatabaseInfo {
             $suspectPage = $true
             $ConfigValues | Add-Member -MemberType NoteProperty -Name 'suspectpageexclude' -Value (Get-DbcConfigValue policy.suspectpage.excludedb)
         }
+        'VirtualLogFile' {
+            $vlf = $true
+            $ConfigValues | Add-Member -MemberType NoteProperty -Name 'maxvlf' -Value (Get-DbcConfigValue policy.database.maxvlf)
+            $ConfigValues | Add-Member -MemberType NoteProperty -Name 'vlfexclude' -Value (Get-DbcConfigValue policy.vlf.excludedb)
+        }
 
         Default { }
     }
@@ -110,6 +115,7 @@ function Get-AllDatabaseInfo {
                 #AsymmetricKeySize   = if ($asymmetrickey) { $psitem.AsymmetricKeys.KeyLength }  # doing this I got $null if there wasn't a key 
                 AutoClose           = if ($autoclose) { $psitem.AutoClose}
                 AutoShrink          = if ($autoshrink) { $psitem.AutoShrink}
+                VLF                 = if ($vlf) { ($psitem.Query("DBCC LOGINFO") | Measure-Object).Count }
             }
         }
     }