Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve message on writing invalid records #229

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

laurentS
Copy link
Collaborator

@laurentS laurentS commented Jan 5, 2023

If the upstream tap changes schema, for instance if the key properties are modified, the target will fail with a confusing message such as:

target_postgres.exceptions.PostgresError: ('Exception writing records', PostgresError("`key_properties` change detected. Existing values are: ['user_id', 'repo', 'org']. Streamed values are: ['user_id', 'repo_id']"))

In many cases, it is very hard to locate the stream that is causing problem, so that remedial action is difficult at best.

This PR simply adds a bit of info to the message to make it easier to fix the problem.

@laurentS laurentS requested a review from ericboucher January 5, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant