Skip to content
This repository has been archived by the owner on Apr 17, 2018. It is now read-only.

Work with ruby 2.3's --enable-frozen-string-literal #90

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jeremyevans
Copy link
Contributor

These changes are the minimal ones necessary to allow Sequel's specs
to pass. There may well be other changes that are required.

These changes are the minimal ones necessary to allow Sequel's specs
to pass. There may well be other changes that are required.
@dbussink
Copy link
Contributor

Curious, how have you been testing this? I tried with RUBYOPT="--enable-frozen-string-literal --debug=frozen-string-literal" but it blows up in other tools like rake and Ruby's own stdlib with that option before it even gets to running any of the DO bits.

@jeremyevans
Copy link
Contributor Author

RUBYOPT="--enable-frozen-string-literal --debug=frozen-string-literal" rake works for Sequel. To deal with frozen string literal issues in dependencies, clone them locally, and set RUBYLIB to include their lib directory.

If you just want to worry about frozen string issues in do itself, just add the # frozen-string-literal: true code to the top of all of the ruby files, then run the tests as you normally would.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants