Skip to content

Commit

Permalink
Merge pull request #69 from dataiku/bug/revert-to-behavior-with-no-no…
Browse files Browse the repository at this point in the history
…de-pool

[sc-181246] revert to previous behavior regarding no specified node pool
  • Loading branch information
amandineslx authored May 16, 2024
2 parents fe66dbe + f1b0ec8 commit 33f6e5e
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 4 deletions.
2 changes: 1 addition & 1 deletion python-clusters/create-eks-cluster/cluster.json
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
"label": "Initial node pool",
"type": "PRESET",
"parameterSetId" : "node-pool-request",
"mandatory" : true
"mandatory" : false
},
{
"name": "nodePools",
Expand Down
3 changes: 0 additions & 3 deletions python-clusters/create-eks-cluster/cluster.py
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,6 @@ def start(self):
if node_pool:
node_pools.append(node_pool)

if not node_pools:
raise Exception("At least one node pool must be defined.")

has_autoscaling = any(node_pool.get('numNodesAutoscaling', False) for node_pool in node_pools)
has_gpu = any(node_pool.get('enableGPU', False) for node_pool in node_pools)

Expand Down

0 comments on commit 33f6e5e

Please sign in to comment.