Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingest/db2): fix handling for table properties #9128

Merged
merged 5 commits into from
Nov 2, 2023
Merged

fix(ingest/db2): fix handling for table properties #9128

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
04b63e9
fix(sqlAlchemySource):failed to ingest IBM Db2 metadata
deepgarg-visa Oct 27, 2023
a2c0cf4
Update metadata-ingestion/src/datahub/ingestion/source/sql/sql_common.py
hsheth2 Oct 27, 2023
27ccd9c
reorder newly added import in sql_common.py to fix lint task
deepgarg-visa Oct 29, 2023
4f31f50
Merge branch 'master' into fix-ibm-db2-ingestion-sqlalchemysource
hsheth2 Nov 1, 2023
1a1fa37
Merge branch 'master' into fix-ibm-db2-ingestion-sqlalchemysource
deepgarg-visa Nov 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion metadata-ingestion/src/datahub/ingestion/source/sql/sql_common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
import sqlalchemy.dialects.postgresql.base
from sqlalchemy import create_engine, inspect
from sqlalchemy.engine.reflection import Inspector
from sqlalchemy.engine.row import LegacyRow
from sqlalchemy.exc import ProgrammingError
from sqlalchemy.sql import sqltypes as types
from sqlalchemy.types import TypeDecorator, TypeEngine
Expand Down Expand Up @@ -784,7 +785,7 @@ def get_table_properties(
table_info: dict = inspector.get_table_comment(table, f'"{schema}"') # type: ignore

description = table_info.get("text")
if type(description) is tuple:
if isinstance(description, LegacyRow):
# Handling for value type tuple which is coming for dialect 'db2+ibm_db'
description = table_info["text"][0]

Expand Down
Loading