fix(ingest): make user_urn and group_urn generation consider user and… #9026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… group urn prefixes
github-actions
bot
added
the
ingestion
|
@shirshanka tests are failing on this pr |
hsheth2
approved these changes
Oct 23, 2023
maggiehays
added
the
hacktoberfest-accepted
anshbansal
added
the
merge-pending-ci
Salman-Apptware
pushed a commit
to Salman-Apptware/datahub
that referenced
this pull request
Dec 15, 2023
datahub-project#9026) Co-authored-by: Aseem Bansal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… group urn prefixes
User and Group urn generation helpers need to take into account all "Identity" urns to avoid double prefixing.
e.g.
make_user_urn("urn:li:corpGroup:foo") should return
urn:li:corpGroup:fooChecklist