Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(ingest/bigquery): fix extracting comments from complex types #8950

Merged
merged 4 commits into from
Oct 27, 2023
Merged

Fix(ingest/bigquery): fix extracting comments from complex types #8950

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
85c2176
Fix comparison to extract comments from complex types
maaaikoool Oct 4, 2023
28b29f7
Update metadata-ingestion/src/datahub/ingestion/source/bigquery_v2/bi…
maaaikoool Oct 25, 2023
92691b9
Merge branch 'master' into fix-bq-ingest-nested-descriptions
maaaikoool Oct 25, 2023
dd96372
Fix lint
maaaikoool Oct 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions metadata-ingestion/src/datahub/ingestion/source/bigquery_v2/bigquery.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1050,8 +1050,14 @@ def gen_schema_fields(self, columns: List[BigqueryColumn]) -> List[SchemaField]:
for idx, field in enumerate(schema_fields):
# Remove all the [version=2.0].[type=struct]. tags to get the field path
if (
re.sub(r"\[.*?\]\.", "", field.fieldPath, 0, re.MULTILINE)
== col.field_path
re.sub(
r"\[.*?\]\.",
"",
field.fieldPath.lower(),
0,
re.MULTILINE,
)
== col.field_path.lower()
):
field.description = col.comment
schema_fields[idx] = field
Expand Down
Loading