fix(ingest/tableau): Fix TableauUpstream create check #12320
+27
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
datahub-cyborg
bot
added
the
needs-review
Codecov ReportAll modified and coverable lines are covered by tests ✅
... and 1508 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
| @@ -247,3 +248,23 @@ def test_optimize_query_filter_handles_no_duplicates(): | |||
| assert len(result) == 2 | |||
| assert result[c.ID_WITH_IN] == ["id1", "id2"] | |||
| assert result[c.PROJECT_NAME_WITH_IN] == ["project1", "project2"] | |||
|
|
|||
|
|
|||
| def testTableaUpstreamReference(): | |||
There was a problem hiding this comment.
following snake case strategy...
Suggested change
| def testTableaUpstreamReference(): | |
| def test_tableau_upstream_reference(): |
| "description": "", | ||
| "columnsConnection": {"totalCount": 0}, | ||
| } | ||
| ref = TableauUpstreamReference.create(d) |
There was a problem hiding this comment.
May a test case for TableauUpstreamReference.create(None) be added?
datahub-cyborg
bot
added
pending-submitter-response
sgomezvillamor
approved these changes
Jan 14, 2025
datahub-cyborg
bot
added
pending-submitter-merge
and removed
pending-submitter-response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist