Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ingestion/snowflake):adds streams as a new dataset with lineage and properties. #12318

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

brock-acryl
Copy link

@brock-acryl brock-acryl commented Jan 10, 2025

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub
    Properly picks up:
  • Streams and columns in a stream (including metadata columns)
  • Stream upstream lineage from show streams statement
  • Stream downstream lineage by parsing queries (tested inserts, CTAS, inserts with unions)
  • Stream properties
Screenshot 2025-01-10 at 11 11 23 AM

@github-actions github-actions bot added ingestion PR or Issue related to the ingestion of metadata community-contribution PR or Issue raised by member(s) of DataHub Community labels Jan 10, 2025
@datahub-cyborg datahub-cyborg bot added the pending-submitter-response Issue/request has been reviewed but requires a response from the submitter label Jan 10, 2025
@datahub-cyborg datahub-cyborg bot added needs-review Label for PRs that need review from a maintainer. and removed pending-submitter-response Issue/request has been reviewed but requires a response from the submitter labels Jan 11, 2025
@brock-acryl brock-acryl reopened this Jan 13, 2025
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 42.16216% with 107 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ingestion/source/snowflake/snowflake_schema_gen.py 30.00% 49 Missing ⚠️
...hub/ingestion/source/snowflake/snowflake_schema.py 58.18% 23 Missing ⚠️
...datahub/ingestion/source/snowflake/snowflake_v2.py 26.31% 14 Missing ⚠️
...ingestion/source/snowflake/snowflake_lineage_v2.py 15.38% 11 Missing ⚠️
...ub/ingestion/source/snowflake/snowflake_queries.py 0.00% 6 Missing ⚠️
...hub/ingestion/source/snowflake/snowflake_report.py 66.66% 2 Missing ⚠️
...ahub/ingestion/source/snowflake/snowflake_query.py 88.88% 1 Missing ⚠️
...ahub/ingestion/source/snowflake/snowflake_utils.py 50.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
...on/src/datahub/ingestion/source/common/subtypes.py 100.00% <100.00%> (ø)
...rc/datahub/ingestion/source/snowflake/constants.py 100.00% <100.00%> (ø)
...hub/ingestion/source/snowflake/snowflake_config.py 97.98% <100.00%> (+0.02%) ⬆️
...ion/src/datahub/ingestion/source/sql/sql_config.py 98.76% <100.00%> (+0.01%) ⬆️
...ahub/ingestion/source/snowflake/snowflake_query.py 93.51% <88.88%> (-0.24%) ⬇️
...ahub/ingestion/source/snowflake/snowflake_utils.py 88.57% <50.00%> (-0.56%) ⬇️
...hub/ingestion/source/snowflake/snowflake_report.py 97.32% <66.66%> (-1.74%) ⬇️
...ub/ingestion/source/snowflake/snowflake_queries.py 43.23% <0.00%> (-0.83%) ⬇️
...ingestion/source/snowflake/snowflake_lineage_v2.py 76.32% <15.38%> (-3.42%) ⬇️
...datahub/ingestion/source/snowflake/snowflake_v2.py 86.04% <26.31%> (-3.19%) ⬇️
... and 2 more

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 457f96e...a268e3e. Read the comment docs.

@datahub-cyborg datahub-cyborg bot added pending-submitter-response Issue/request has been reviewed but requires a response from the submitter and removed needs-review Label for PRs that need review from a maintainer. labels Jan 14, 2025
- moved stream lineage from snowflake_v2.py & snowflake_lineage_v2.py to snowflake_schema_gen.py
- updated snowflake_schema_gen.py to use snowflake_utils.py
@datahub-cyborg datahub-cyborg bot added needs-review Label for PRs that need review from a maintainer. and removed pending-submitter-response Issue/request has been reviewed but requires a response from the submitter labels Jan 14, 2025
- changed from clone table logic to manually mapping columns since metadata columns were attempting to be mapped from the stream source
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community ingestion PR or Issue related to the ingestion of metadata needs-review Label for PRs that need review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants