-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ingestion/snowflake):adds streams as a new dataset with lineage and properties. #12318
Open
brock-acryl
wants to merge
10
commits into
datahub-project:master
Choose a base branch
from
brock-acryl:snowflake-streams-v2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(ingestion/snowflake):adds streams as a new dataset with lineage and properties. #12318
brock-acryl
wants to merge
10
commits into
datahub-project:master
from
brock-acryl:snowflake-streams-v2
+515
−70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ingestion
PR or Issue related to the ingestion of metadata
community-contribution
PR or Issue raised by member(s) of DataHub Community
labels
Jan 10, 2025
gabe-lyons
reviewed
Jan 10, 2025
metadata-ingestion/src/datahub/ingestion/source/snowflake/snowflake_queries.py
Show resolved
Hide resolved
gabe-lyons
reviewed
Jan 10, 2025
metadata-ingestion/src/datahub/ingestion/source/snowflake/snowflake_query.py
Outdated
Show resolved
Hide resolved
datahub-cyborg
bot
added
the
pending-submitter-response
Issue/request has been reviewed but requires a response from the submitter
label
Jan 10, 2025
datahub-cyborg
bot
added
needs-review
Label for PRs that need review from a maintainer.
and removed
pending-submitter-response
Issue/request has been reviewed but requires a response from the submitter
labels
Jan 11, 2025
brock-acryl
force-pushed
the
snowflake-streams-v2
branch
from
January 13, 2025 16:22
c9e611d
to
457f96e
Compare
metadata-ingestion/src/datahub/ingestion/source/sql/sql_config.py
Outdated
Show resolved
Hide resolved
metadata-ingestion/src/datahub/ingestion/source/snowflake/snowflake_v2.py
Show resolved
Hide resolved
metadata-ingestion/src/datahub/ingestion/source/snowflake/snowflake_schema_gen.py
Outdated
Show resolved
Hide resolved
metadata-ingestion/src/datahub/ingestion/source/snowflake/snowflake_v2.py
Outdated
Show resolved
Hide resolved
metadata-ingestion/src/datahub/ingestion/source/snowflake/snowflake_query.py
Outdated
Show resolved
Hide resolved
metadata-ingestion/src/datahub/ingestion/source/snowflake/snowflake_schema_gen.py
Outdated
Show resolved
Hide resolved
metadata-ingestion/src/datahub/ingestion/source/snowflake/snowflake_v2.py
Outdated
Show resolved
Hide resolved
datahub-cyborg
bot
added
pending-submitter-response
Issue/request has been reviewed but requires a response from the submitter
and removed
needs-review
Label for PRs that need review from a maintainer.
labels
Jan 14, 2025
- moved stream lineage from snowflake_v2.py & snowflake_lineage_v2.py to snowflake_schema_gen.py - updated snowflake_schema_gen.py to use snowflake_utils.py
datahub-cyborg
bot
added
needs-review
Label for PRs that need review from a maintainer.
and removed
pending-submitter-response
Issue/request has been reviewed but requires a response from the submitter
labels
Jan 14, 2025
- changed from clone table logic to manually mapping columns since metadata columns were attempting to be mapped from the stream source
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
community-contribution
PR or Issue raised by member(s) of DataHub Community
ingestion
PR or Issue related to the ingestion of metadata
needs-review
Label for PRs that need review from a maintainer.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Properly picks up: