Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(models): update mlflow-related mappers #12263

Merged
merged 19 commits into from
Jan 13, 2025

Conversation

yoonhyejin
Copy link
Collaborator

@yoonhyejin yoonhyejin commented Jan 3, 2025

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

mapper changes + adding minimum frontend files to not break the smoke tests

@yoonhyejin
Copy link
Collaborator Author

unit test & builds are failing temporally because of the badssl issue: chromium/badssl.com#541

Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most comments are around our need for additional tests - we are holding ourselves to a higher bar in test coverage & quality nowadays - but in general the changes looks good!

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 28.45528% with 264 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
.../dataProcessInstance/DataProcessInstanceEntity.tsx 31.43% 181 Missing ⚠️
...app/entity/dataProcessInstance/preview/Preview.tsx 19.41% 83 Missing ⚠️
Files with missing lines Coverage Δ
datahub-web-react/src/app/buildEntityRegistry.ts 100.00% <100.00%> (ø)
...src/main/java/com/linkedin/metadata/Constants.java 0.00% <ø> (ø)
...app/entity/dataProcessInstance/preview/Preview.tsx 19.41% <19.41%> (ø)
.../dataProcessInstance/DataProcessInstanceEntity.tsx 31.43% <31.43%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9897804...e0e80e9. Read the comment docs.

@RyanHolstien RyanHolstien changed the title feat: update mlflow-related mappers feat(models): update mlflow-related mappers Jan 13, 2025
@RyanHolstien RyanHolstien marked this pull request as ready for review January 13, 2025 20:07
@RyanHolstien RyanHolstien merged commit ddd0d21 into datahub-project:master Jan 13, 2025
204 of 208 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops PR or Issue related to DataHub backend & deployment pending-submitter-merge product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants