-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(models): update mlflow-related mappers #12263
feat(models): update mlflow-related mappers #12263
Conversation
unit test & builds are failing temporally because of the badssl issue: chromium/badssl.com#541 |
...ain/java/com/linkedin/datahub/graphql/types/dataprocessinstance/DataProcessInstanceType.java
Outdated
Show resolved
Hide resolved
...va/com/linkedin/datahub/graphql/types/dataprocessinst/mappers/DataProcessInstanceMapper.java
Show resolved
Hide resolved
...main/java/com/linkedin/datahub/graphql/types/common/mappers/TimeStampToAuditStampMapper.java
Show resolved
Hide resolved
...java/com/linkedin/datahub/graphql/types/common/mappers/DataPlatformInstanceAspectMapper.java
Show resolved
Hide resolved
...ub-graphql-core/src/main/java/com/linkedin/datahub/graphql/resolvers/search/SearchUtils.java
Outdated
Show resolved
Hide resolved
datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/GmsGraphQLEngine.java
Show resolved
Hide resolved
datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/GmsGraphQLEngine.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most comments are around our need for additional tests - we are holding ourselves to a higher bar in test coverage & quality nowadays - but in general the changes looks good!
Codecov ReportAttention: Patch coverage is
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
...va/com/linkedin/datahub/graphql/types/dataprocessinst/mappers/DataProcessInstanceMapper.java
Outdated
Show resolved
Hide resolved
775983e
to
ae35b0d
Compare
ddd0d21
into
datahub-project:master
Checklist
mapper changes + adding minimum frontend files to not break the smoke tests