feat(ingest/snowflake): support email_as_user_identifier for queries v2 #12219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
datahub-cyborg
bot
added
the
needs-review
sgomezvillamor
approved these changes
Dec 24, 2024
| @@ -225,6 +227,9 @@ def is_allowed_table(self, name: str) -> bool: | |||
| def get_workunits_internal( | |||
| self, | |||
| ) -> Iterable[MetadataWorkUnit]: | |||
| with self.report.users_fetch_timer: | |||
| users = self.fetch_users() | |||
There was a problem hiding this comment.
It can be tough to figure out what's in the dictionary (key and value) especially when variables go through different methods. To help, I suggest using a more descriptive name or a type alias to clearly describe the content.
There was a problem hiding this comment.
looks better now ?
Comment on lines
37
to
38
| "email_as_user_identifier": True, | ||
| "email_domain": "example.com", |
There was a problem hiding this comment.
do we miss the case below? it that makes sense
email_as_user_identifier: True
email_domain: None
There was a problem hiding this comment.
That's true -> I'll add that to test -> but in this case - we'd do best effort and then if email still can't be formed then use username for urn.
datahub-cyborg
bot
added
pending-submitter-merge
and removed
needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist